This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff eeb4981...b19f463.
|
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits b19f463 and eeb4981 or learn more. Open explanation
|
valerybugakov
approved these changes
Feb 15, 2023
philipp-spiess
approved these changes
Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for https://github.com/sourcegraph/sourcegraph/pull/47572
Prior to this PR, even if we specified the Tab component with lazy true and behaviour memoise, we rendered only the active tab, and there was a jump between tab switching since we were doing show logic in the use effect hook. In this PR we
Test plan
App preview:
Check out the client app preview documentation to learn more.